Add comprehensive hardware breakpoint support for all debug adapters with UI integration#859
Closed
Add comprehensive hardware breakpoint support for all debug adapters with UI integration#859
Conversation
Co-authored-by: xusheng6 <94503187+xusheng6@users.noreply.github.com>
|
|
Co-authored-by: xusheng6 <94503187+xusheng6@users.noreply.github.com>
Co-authored-by: xusheng6 <94503187+xusheng6@users.noreply.github.com>
Co-authored-by: xusheng6 <94503187+xusheng6@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Support hardware breakpoint
Add comprehensive hardware breakpoint support for all debug adapters
Sep 24, 2025
Member
|
@copilot
|
Contributor
Author
I'll implement these three enhancements:
Let me implement these changes step by step.
I've implemented all three requested enhancements: 1. DbgEng Adapter Hardware Breakpoint Support ✅Added complete hardware breakpoint support using WinDbg's
2. Hardware Breakpoint UI Dialog ✅Created new
3. Enhanced Breakpoint List with Type Column ✅Extended breakpoint list to show breakpoint types:
Here are mockups showing the UI enhancements: Key Features:
Commit: 7cb6ddd |
Co-authored-by: xusheng6 <94503187+xusheng6@users.noreply.github.com>
…with UI integration Co-authored-by: xusheng6 <94503187+xusheng6@users.noreply.github.com>
Copilot
AI
changed the title
Add comprehensive hardware breakpoint support for all debug adapters
Add comprehensive hardware breakpoint support for all debug adapters with UI integration
Sep 25, 2025
Member
|
Already added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR implements comprehensive hardware breakpoint and watchpoint support across all debug adapters (LLDB, GDB RSP, Esreven, DbgEng), addressing a long-standing feature request with full UI integration.
Key Features
Standardized API
DebugBreakpointTypeenum with support for:AddHardwareBreakpoint()andRemoveHardwareBreakpoint()with size parameter supportCross-Adapter Implementation
bacommands (ba e/r/w/a for execute/read/write/access)Complete UI Integration
HardwareBreakpointDialogwith address input, type selection (Execute, Read, Write, Access), size configuration for watchpoints, and contextual helpPython API Integration
Backend Command Support
For advanced users, direct backend commands remain available:
Implementation Details
AddBreakpoint()methods now handle hardware breakpoint typesFiles Changed
debuggercommon.h,debugadapter.h/.cpp,ffi.cppdebuggerapi.h,debuggercontroller.cpp,ffi.hlldbadapter.h/.cpp,gdbadapter.h/.cpp,esrevenadapter.h/.cpp,dbgengadapter.h/.cppbreakpointswidget.h/.cpp,hardwarebreakpointdialog.h/.cppThe implementation provides a complete hardware breakpoint solution with intuitive UI integration while maintaining architectural consistency and ensuring all existing functionality continues to work unchanged.
Fixes #53.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.